Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables ...................................................................... Patch Set 19: (5 comments) http://gerrit.cloudera.org:8080/#/c/17842/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17842/19//COMMIT_MSG@11 PS19, Line 11: It has some limitations due to the restrictions of "external data There are likely other restrictions? Can we run more complex queries where we perform JOIN/GROUP-BY/OLAP/SORT on external data source table with another external data source table or regular table? Do we support generating these kind of plans today? http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@83 PS19, Line 83: scanHandle_ What's the purpose of ScanHandle? It's a string and it's just set to some random UUID? http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@84 PS19, Line 84: private boolean cacheClass_ = false; What are we caching? Some comments here would be useful as this isn't obvious. http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@86 PS19, Line 86: private Configuration tableConfig_; What exactly is a table Config? Comments would be good. http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@98 PS19, Line 98: craete typo: 'craete' -> 'create' -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 19 Gerrit-Owner: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fucun Chu <chufu...@hotmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2023 21:28:15 +0000 Gerrit-HasComments: Yes
