Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables ...................................................................... Patch Set 20: (5 comments) http://gerrit.cloudera.org:8080/#/c/17842/19//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17842/19//COMMIT_MSG@11 PS19, Line 11: It has some limitations due to the restrictions of "external data > There are likely other restrictions? Added supported database types. Also added more complex queries: inner join with non jdbc table, inner join with another jdbc table, cross join with order, group by. http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@83 PS19, Line 83: entify Jdbc > What's the purpose of ScanHandle? It's a string and it's just set to some r Handle to identify JdbcDataSource object. It's assigned with random UUID value in open() API, and verified in getNext() and close() APIs to make sure caller use valid JdbcDataSource object. Added comments. http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@84 PS19, Line 84: // It's assigned with random UUID value in open() API, and returned to the caller. > What are we caching? Some comments here would be useful as this isn't obvio added comments http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@86 PS19, Line 86: // input parameters to make sure the object is valid. > What exactly is a table Config? Comments would be good. It's a map to save table properties. Added comments. http://gerrit.cloudera.org:8080/#/c/17842/19/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@98 PS19, Line 98: > typo: fixed -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 20 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Sat, 30 Sep 2023 00:23:25 +0000 Gerrit-HasComments: Yes
