Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables ...................................................................... Patch Set 21: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/17842/21//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17842/21//COMMIT_MSG@11 PS21, Line 11: It has some limitations due to the restrictions of "external data There also seems to be restrictions on column data types being received from external table. Based on the `next` implementation in JdbcRecordIterator class following types aren't supported: COMPLEX, BINARY, CHAR, DATETIME http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@148 PS21, Line 148: // 1. Check init string : if (!convertInitStringToConfiguration(params.getInit_string())) { : return new TOpenResult( : new TStatus(TErrorCode.INTERNAL_ERROR, : Lists.newArrayList("Invalid init_string value"))); : } This is the same check as one in prepare(). Is there a case where you could still call open() if prepare() failed with an error? http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java: http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@95 PS21, Line 95: private static boolean isEmptyString(String value) { We don't seem to be calling this function anywhere? http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java: http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@66 PS21, Line 66: protected DataSource dbcpDataSource = null; `dbcpDataSource_` for instance variables http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java@68 PS21, Line 68: public static Cache<String, DataSource> dataSourceCache = CacheBuilder naming convention: `dataSourceCache_` http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java File java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java: http://gerrit.cloudera.org:8080/#/c/17842/21/java/ext-data-source/jdbc/src/main/java/org/apache/impala/extdatasource/jdbc/dao/JdbcRecordIterator.java@53 PS21, Line 53: private final Connection conn; proper naming convention for all instance variables. -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 21 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 02 Oct 2023 02:19:21 +0000 Gerrit-HasComments: Yes
