Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables ...................................................................... Patch Set 22: (5 comments) http://gerrit.cloudera.org:8080/#/c/17842/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17842/22//COMMIT_MSG@11 PS22, Line 11: It has some limitations due to the restrictions of "external data : source": nit: I assume this patch is also still limited by IMPALA-7131 (does not work for Catalog V2)? If yes, can we mention it here? http://gerrit.cloudera.org:8080/#/c/17842/22//COMMIT_MSG@39 PS22, Line 39: -i ${IMPALAD} nit: This can be removed? impala-shell will connect to first impalad. http://gerrit.cloudera.org:8080/#/c/17842/22/testdata/bin/copy-data-sources.sh File testdata/bin/copy-data-sources.sh: http://gerrit.cloudera.org:8080/#/c/17842/22/testdata/bin/copy-data-sources.sh@28 PS22, Line 28: ${FILESYSTEM_PREFIX}/test-warehouse/data-sources/ nit: Contain this path into its own bash variable and use that for the following commands? http://gerrit.cloudera.org:8080/#/c/17842/22/testdata/bin/copy-data-sources.sh@40 PS22, Line 40: hadoop fs -put -f \ : ${IMPALA_HOME}/fe/target/dependency/postgresql-*.jar \ : ${FILESYSTEM_PREFIX}/test-warehouse/data-sources/jdbc-driver/postgresql-jdbc.jar nit: print something at the end of this script to indicate successful run? Maybe like "Copied xxx.jar into <hdfs_path>.". http://gerrit.cloudera.org:8080/#/c/17842/22/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test File testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test: http://gerrit.cloudera.org:8080/#/c/17842/22/testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test@28 PS22, Line 28: 11,false,1,1,1,10,1.100000023841858,10.1,'01/02/09','1',2009-01-02 00:11:00.450000000 : 12,true,2,2,2,20,2.200000047683716,20.2,'01/02/09','2',2009-01-02 00:12:00.460000000 : 13,false,3,3,3,30,3.299999952316284,30.3,'01/02/09','3',2009-01-02 00:13:00.480000000 : 14,true,4,4,4,40,4.400000095367432,40.4,'01/02/09','4',2009-01-02 00:14:00.510000000 : 20,true,0,0,0,0,0,0,'01/03/09','0',2009-01-03 00:20:00.900000000 Tried to run the test myself and I get following error: -- 2023-10-02 11:22:20,076 INFO MainThread: Started query b548955a0c538511:6d16651b00000000 -- executing against localhost:21000 select * from alltypes_jdbc_datasource where id > 10 and int_col< 5 limit 5; -- 2023-10-02 11:22:20,324 INFO MainThread: Started query 95474cb079f2d042:878687c800000000 -- 2023-10-02 11:22:20,439 ERROR MainThread: Comparing QueryTestResults (expected vs actual): 11,false,1,1,1,10,1.100000023841858,10.1,'01/02/09','1',2009-01-02 00:11:00.450000000 != 11,false,1,1,1,10,1.100000023841858,10.1,'01/02/09','1',2009-01-02 08:11:00.450000000 12,true,2,2,2,20,2.200000047683716,20.2,'01/02/09','2',2009-01-02 00:12:00.460000000 != 12,true,2,2,2,20,2.200000047683716,20.2,'01/02/09','2',2009-01-02 08:12:00.460000000 13,false,3,3,3,30,3.299999952316284,30.3,'01/02/09','3',2009-01-02 00:13:00.480000000 != 13,false,3,3,3,30,3.299999952316284,30.3,'01/02/09','3',2009-01-02 08:13:00.480000000 14,true,4,4,4,40,4.400000095367432,40.4,'01/02/09','4',2009-01-02 00:14:00.510000000 != 14,true,4,4,4,40,4.400000095367432,40.4,'01/02/09','4',2009-01-02 08:14:00.510000000 20,true,0,0,0,0,0,0,'01/03/09','0',2009-01-03 00:20:00.900000000 != 20,true,0,0,0,0,0,0,'01/03/09','0',2009-01-03 08:20:00.900000000 Other test cases passed. Is there something non-deterministic during data loading? -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 22 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 02 Oct 2023 18:40:24 +0000 Gerrit-HasComments: Yes
