Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17842 )
Change subject: IMPALA-5741: Initial support for reading tiny RDBMS tables ...................................................................... Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/17842/22//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17842/22//COMMIT_MSG@33 PS22, Line 33: copy-data-sources.sh nit: General comment about naming: instead of referring things with *data-source* in this patch, maybe *ext-data-source* or *jdbc-data-source* is more precise? So the script names will be something like: copy-ext-data-sources.sh create-ext-data-source-table.sql load-ext-data-sources.sh -- To view, visit http://gerrit.cloudera.org:8080/17842 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8244e978c7717c6f1452f66f1630b6441392e7d2 Gerrit-Change-Number: 17842 Gerrit-PatchSet: 22 Gerrit-Owner: Fucun Chu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 02 Oct 2023 19:06:42 +0000 Gerrit-HasComments: Yes
