Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 )
Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20538/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20538/6//COMMIT_MSG@48 PS6, Line 48: Unit tests produce JUnitXML for integration with jenkins jobs, : these are stored in ${IMPALA_JS_TEST_LOGS_DIR}. I tried to run Jenkins job with BE_TEST. >From console output, I could see JS Tests has been ran successfully. But the JS Tests result is not shown Test Result page. You need to extend the code for Jenkins job to show the JS Test result. http://gerrit.cloudera.org:8080/#/c/20538/6/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/20538/6/bin/run-all-tests.sh@64 PS6, Line 64: # Run JS tests : : ${JS_TEST:=${BE_TEST}} It's fine to set it BE_TEST now. I would like to have a separate setting for JS Tests in future. http://gerrit.cloudera.org:8080/#/c/20538/6/tests/run-js-tests.sh File tests/run-js-tests.sh: http://gerrit.cloudera.org:8080/#/c/20538/6/tests/run-js-tests.sh@40 PS6, Line 40: curl https://nodejs.org/dist/${NODEJS_VERSION}/node-${NODEJS_VERSION}-${NODEJS_DISTRO}.tar.xz -O > line too long (98 > 90) You can break this down using local variable so the line can be shorter. http://gerrit.cloudera.org:8080/#/c/20538/6/tests/run-js-tests.sh@49 PS6, Line 49: nit: two more spaces -- To view, visit http://gerrit.cloudera.org:8080/20538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0caf0a0beee23821f78c0b3fe1aeb7dbf92d6a3e Gerrit-Change-Number: 20538 Gerrit-PatchSet: 6 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 25 Oct 2023 22:11:51 +0000 Gerrit-HasComments: Yes
