Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 )
Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20538/7/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/20538/7/bin/run-all-tests.sh@65 PS7, Line 65: ${JS_TEST:=${BE_TEST}} > BE_TEST is set as true by default. I suggest to set JS_TEST as false by def Yes, I feel the same way. RHEL 8.4 and above support GLIBC 2.28(Node v16) hence are able to run tests, but RHEL 7 and older distributions have much lower GLIBC versions and will fail to run the test. http://gerrit.cloudera.org:8080/#/c/20538/7/tests/run-js-tests.sh File tests/run-js-tests.sh: http://gerrit.cloudera.org:8080/#/c/20538/7/tests/run-js-tests.sh@40 PS7, Line 40: / > nit: it's better to remove '/' here and change line #42 as Done -- To view, visit http://gerrit.cloudera.org:8080/20538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0caf0a0beee23821f78c0b3fe1aeb7dbf92d6a3e Gerrit-Change-Number: 20538 Gerrit-PatchSet: 7 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2023 12:15:13 +0000 Gerrit-HasComments: Yes
