Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/20538 )
Change subject: IMPALA-12415: Implement tests for graphical query timeline in webUI ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/20538/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20538/6//COMMIT_MSG@48 PS6, Line 48: Unit tests produce JUnitXML for integration with jenkins jobs, : these are stored in ${IMPALA_JS_TEST_LOGS_DIR}. > I tried to run Jenkins job with BE_TEST. From console output, I could see J Sure. I will look into this once it is merged. http://gerrit.cloudera.org:8080/#/c/20538/6/tests/run-js-tests.sh File tests/run-js-tests.sh: http://gerrit.cloudera.org:8080/#/c/20538/6/tests/run-js-tests.sh@33 PS6, Line 33: IMPALA_JS_TEST_LOGS_DIR > js-tests.xml was generated in this folder when ran this script. But I did n The test failures are also stored within the js-tests.xml. Only in case of error, the usual report_build_error.sh is triggered, which generates logs in a different directory. http://gerrit.cloudera.org:8080/#/c/20538/6/tests/run-js-tests.sh@40 PS6, Line 40: NODE_URL_PREFIX="https://nodejs.org/dist/"; > You can break this down using local variable so the line can be shorter. Done http://gerrit.cloudera.org:8080/#/c/20538/6/tests/run-js-tests.sh@49 PS6, Line 49: > nit: two more spaces Done http://gerrit.cloudera.org:8080/#/c/20538/6/www/scripts/query_timeline/chart_commons.js File www/scripts/query_timeline/chart_commons.js: http://gerrit.cloudera.org:8080/#/c/20538/6/www/scripts/query_timeline/chart_commons.js@64 PS6, Line 64: for (var i = 0 > nit: don't need to define this variable out of loop, define it directly in Done -- To view, visit http://gerrit.cloudera.org:8080/20538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0caf0a0beee23821f78c0b3fe1aeb7dbf92d6a3e Gerrit-Change-Number: 20538 Gerrit-PatchSet: 7 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2023 15:04:11 +0000 Gerrit-HasComments: Yes
