Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20624 )
Change subject: IMPALA-12517: Decode binary data with Python 3 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/20624/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/20624/2/tests/shell/test_shell_commandline.py@1190 PS2, Line 1190: query = "select binary_col from functional.binary_tbl" can you also add a test for the case of invalid utf8 byte sequences when "replace" logic is used? See test_utf8_decoding_error_handling for examples That test could be also extended to check both STRING and BINARY results. -- To view, visit http://gerrit.cloudera.org:8080/20624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9222cd1ac081a38ab2b37d58628faac0812695ec Gerrit-Change-Number: 20624 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2023 12:58:27 +0000 Gerrit-HasComments: Yes
