Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20624 )
Change subject: IMPALA-12517: Decode binary data with Python 3 ...................................................................... Patch Set 3: Code-Review+2 I think it makes sense to match the Python 2 behavior first, then do other things in separate changes. Bumping to +2 One option: Looking at testdata/data/binary_tbl/000000_0.txt, the binary column is base64 encoded. We could provide that as an option for binary output (e.g. for batch mode). That would allow for correct data export for CSV. -- To view, visit http://gerrit.cloudera.org:8080/20624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9222cd1ac081a38ab2b37d58628faac0812695ec Gerrit-Change-Number: 20624 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 31 Oct 2023 18:04:02 +0000 Gerrit-HasComments: No
