Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20624 )
Change subject: IMPALA-12517: Decode binary data with Python 3 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20624/2/shell/value_converter.py File shell/value_converter.py: http://gerrit.cloudera.org:8080/#/c/20624/2/shell/value_converter.py@37 PS2, Line 37: return lambda s: s.decode(errors='replace') > What do you think about 'backslashreplace'? It needs Python 3.5 or above, b Since the behavior isn't well-defined, I was leaning towards trying to match Python 2 behavior. http://gerrit.cloudera.org:8080/#/c/20624/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/20624/2/tests/shell/test_shell_commandline.py@1190 PS2, Line 1190: query = "select binary_col from functional.binary_tbl" > can you also add a test for the case of invalid utf8 byte sequences when "r Done -- To view, visit http://gerrit.cloudera.org:8080/20624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9222cd1ac081a38ab2b37d58628faac0812695ec Gerrit-Change-Number: 20624 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2023 17:50:27 +0000 Gerrit-HasComments: Yes
