Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20515 )
Change subject: IMPALA-12243: Add support for DROP PARTITION for Iceberg tables ...................................................................... Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/analysis/PartitionSet.java File fe/src/main/java/org/apache/impala/analysis/PartitionSet.java: http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/analysis/PartitionSet.java@203 PS5, Line 203: * Rewrites SlotRefs and FunctionCallExprs as IcebergPartitionExpr. SlotRefs targeting a line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/analysis/PartitionSet.java@207 PS5, Line 207: * where the transform is located from the function name, and the parameter (if there's line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/analysis/PartitionSet.java@210 PS5, Line 210: * the original SlotRef/FunctionCallExpr. For Date transforms (year, month, day, hour), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/analysis/PartitionSet.java@319 PS5, Line 319: Integer dateTimeTransformValue = IcebergUtil.getDateTimeTransformValue(transformType, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/analysis/PartitionSet.java@336 PS5, Line 336: org.apache.iceberg.PartitionSpec spec = ((IcebergTable) table_).getIcebergApiTable().spec(); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/analysis/PartitionSet.java@342 PS5, Line 342: org.apache.iceberg.PartitionSpec spec = ((IcebergTable) table_).getIcebergApiTable().spec(); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@440 PS5, Line 440: public void loadSchemaFromIceberg() throws TableLoadingException, ImpalaRuntimeException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/20515/5/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@756 PS5, Line 756: TIcebergPartitionTransformType transformType, String stringValue) throws ImpalaRuntimeException { line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a768ba2966f570454687e02e4e6d67df46741f9 Gerrit-Change-Number: 20515 Gerrit-PatchSet: 5 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 06 Nov 2023 08:36:02 +0000 Gerrit-HasComments: Yes
