Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20515 )
Change subject: IMPALA-12243: Add support for DROP PARTITION for Iceberg tables ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/20515/7/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/20515/7/common/thrift/CatalogObjects.thrift@630 PS7, Line 630: // List of affected file paths (could be empty if the drop partition request can be exchanged line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/20515/7/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java: http://gerrit.cloudera.org:8080/#/c/20515/7/fe/src/main/java/org/apache/impala/analysis/AlterTableDropPartitionStmt.java@141 PS7, Line 141: new IcebergPartitionExpressionRewriter(analyzer, table.getIcebergApiTable().spec()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20515/7/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpressionRewriter.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpressionRewriter.java: http://gerrit.cloudera.org:8080/#/c/20515/7/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpressionRewriter.java@35 PS7, Line 35: public IcebergPartitionExpressionRewriter(Analyzer analyzer, org.apache.iceberg.PartitionSpec partitionSpec) { line too long (112 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a768ba2966f570454687e02e4e6d67df46741f9 Gerrit-Change-Number: 20515 Gerrit-PatchSet: 7 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 09 Nov 2023 15:20:07 +0000 Gerrit-HasComments: Yes
