Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20490 )
Change subject: IMPALA-12448: Avoid getting stuck when refreshing a non-existent partition ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/20490/10/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/20490/10/be/src/catalog/catalog-server.cc@156 PS10, Line 156: the topic nit: To be more clear, let's mention "the catalog topic" http://gerrit.cloudera.org:8080/#/c/20490/10/be/src/catalog/catalog-server.cc@156 PS10, Line 156: "of the topic update log are garbage collected."); nit: Let's explain more in the description: A catalog entry may survive for (2 * topic_update_log_gc_frequency) - 1 topic updates. http://gerrit.cloudera.org:8080/#/c/20490/10/tests/metadata/test_refresh_partition.py File tests/metadata/test_refresh_partition.py: http://gerrit.cloudera.org:8080/#/c/20490/10/tests/metadata/test_refresh_partition.py@27 PS10, Line 27: CustomClusterTestSuite This impacts other tests in this class. Custom cluster tests are slow since each test require restarting the Impala cluster. So we only do it when we need customized startup flags. Please put the new test in a new test python script and add it under tests/custom/ -- To view, visit http://gerrit.cloudera.org:8080/20490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887 Gerrit-Change-Number: 20490 Gerrit-PatchSet: 10 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Tue, 07 Nov 2023 08:26:19 +0000 Gerrit-HasComments: Yes
