ttttttz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20490 )

Change subject: IMPALA-12448: Avoid getting stuck when refreshing a 
non-existent partition
......................................................................


Patch Set 11:

(3 comments)

Thanks Quanlong! I have submitted the latest code.

http://gerrit.cloudera.org:8080/#/c/20490/10/be/src/catalog/catalog-server.cc
File be/src/catalog/catalog-server.cc:

http://gerrit.cloudera.org:8080/#/c/20490/10/be/src/catalog/catalog-server.cc@156
PS10, Line 156:     "of the catalog topic update log are garbage collected. An 
entry may survive "
> nit: Let's explain more in the description:
Done


http://gerrit.cloudera.org:8080/#/c/20490/10/be/src/catalog/catalog-server.cc@156
PS10, Line 156: the catal
> nit: To be more clear, let's mention "the catalog topic"
Done


http://gerrit.cloudera.org:8080/#/c/20490/10/tests/metadata/test_refresh_partition.py
File tests/metadata/test_refresh_partition.py:

http://gerrit.cloudera.org:8080/#/c/20490/10/tests/metadata/test_refresh_partition.py@27
PS10, Line 27:
> This impacts other tests in this class. Custom cluster tests are slow since
Done



--
To view, visit http://gerrit.cloudera.org:8080/20490
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887
Gerrit-Change-Number: 20490
Gerrit-PatchSet: 11
Gerrit-Owner: ttttttz <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
Gerrit-Comment-Date: Tue, 07 Nov 2023 09:10:20 +0000
Gerrit-HasComments: Yes

Reply via email to