Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20490 )
Change subject: IMPALA-12448: Avoid getting stuck when refreshing a non-existent partition ...................................................................... Patch Set 13: (1 comment) The fix looks good to me. Just one minor concern on flaky test. http://gerrit.cloudera.org:8080/#/c/20490/13/fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java File fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java: http://gerrit.cloudera.org:8080/#/c/20490/13/fe/src/main/java/org/apache/impala/catalog/TopicUpdateLog.java@46 PS13, Line 46: private final static int TOPIC_UPDATE_LOG_GC_FREQUENCY = BackendConfig.INSTANCE I'm not sure if any FE test use this class. There are some FE tests that can't assure BackendConfig.INSTANCE is initiated. We've seen flaky test failures like IMPALA-11699, IMPALA-12526. It'd be safer to use BackendConfig.INSTANCE to init a non-static field, e.g. topic_update_log_gc_frequency_. -- To view, visit http://gerrit.cloudera.org:8080/20490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iace7cdadda300b03896f92415822266354421887 Gerrit-Change-Number: 20490 Gerrit-PatchSet: 13 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Mon, 20 Nov 2023 08:06:41 +0000 Gerrit-HasComments: Yes
