Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20657 )
Change subject: IMPALA-12525: Fix flaky test test_statestored_manual_failover ...................................................................... Patch Set 5: (4 comments) I'd like to see Riza's suggestions addressed to. http://gerrit.cloudera.org:8080/#/c/20657/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20657/4//COMMIT_MSG@12 PS4, Line 12: > fixed Done http://gerrit.cloudera.org:8080/#/c/20657/4//COMMIT_MSG@30 PS4, Line 30: subscribers could be started before both statestore instances are > fixed Done http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore-subscriber.cc@1108 PS4, Line 1108: int64_t StatestoreSubscriber::StatestoreStub::GetActiveVersion(bool* is_active) { > Right, remove it Done http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore.cc@2039 PS4, Line 2039: } > fixed as suggested Done -- To view, visit http://gerrit.cloudera.org:8080/20657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If03bf09d22a2875d2c1eec8a4f62eeefc5d855dc Gerrit-Change-Number: 20657 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 08 Nov 2023 00:05:53 +0000 Gerrit-HasComments: Yes
