Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20657 )
Change subject: IMPALA-12525: Fix flaky test test_statestored_manual_failover ...................................................................... Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore-subscriber.cc@387 PS4, Line 387: *active_statestore_conn_state = statestore2_->GetStatestoreConnState(); > This is on the calling path of heartbeat message. It could flood log file i Make sense. http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore-subscriber.cc@445 PS4, Line 445: standby_statestore_->SetStatestoreActive(!is_active, active_statestored_version); : LOG(INFO) << "Updated active statestored as " << active_statestore_->GetAddress(); : } : > I was thinking the issue was caused by holding two locks so moving the code Now that it is put back within statestore_ha_lock_, maybe try loop the test one more time to confirm no issue. http://gerrit.cloudera.org:8080/#/c/20657/4/be/src/statestore/statestore-subscriber.cc@461 PS4, Line 461: DCHECK(standby_statestore_ == nullptr); : // Active/standby statestored are not set. This could > Added a log message. Done -- To view, visit http://gerrit.cloudera.org:8080/20657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If03bf09d22a2875d2c1eec8a4f62eeefc5d855dc Gerrit-Change-Number: 20657 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 08 Nov 2023 02:49:02 +0000 Gerrit-HasComments: Yes
