Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20657 )
Change subject: IMPALA-12525: Fix flaky test test_statestored_manual_failover ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20657/7/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/20657/7/be/src/statestore/statestore-subscriber.cc@451 PS7, Line 451: active_statestore->UpdateCatalogd(*catalogd_registration, registration_id, > Could avoiding a lock here result in sending two updates to catalogd that a Out-of-order of two updates to catalogd is already handled on the receiver side by checking the version. Two thrift RPCs could be received out-of-order since they use separate TCP connections. We should avoid to hold lock when sending RPCs. -- To view, visit http://gerrit.cloudera.org:8080/20657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If03bf09d22a2875d2c1eec8a4f62eeefc5d855dc Gerrit-Change-Number: 20657 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 08 Nov 2023 18:58:37 +0000 Gerrit-HasComments: Yes
