Hello Daniel Becker, Yida Wu, Joe McDonnell, Csaba Ringhofer, Impala Public
Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20692
to look at the new patch set (#9).
Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager
......................................................................
IMPALA-11542: Implement pre-allocation in LLVM memory manager
Implements up-front allocation for the LLVM memory manager to avoid
disparate sections on ARM which can exceed the 4GB limit for ADRP
instructions and crash (or hit an assertion in debug mode).
This is an LLVM issue that we're fixing by providing a custom memory
manager. See the JIRA and
https://discourse.llvm.org/t/llvm-rtdyld-aarch64-abi-relocation-restrictions/74616
for further discussion.
Testing:
- passes debug test run on ARM
- pre-commit tests
Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675
---
M be/src/codegen/SectionMemoryManager.cc
M be/src/codegen/SectionMemoryManager.h
M be/src/codegen/mcjit-mem-mgr.h
3 files changed, 79 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/20692/9
--
To view, visit http://gerrit.cloudera.org:8080/20692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675
Gerrit-Change-Number: 20692
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
