David Knupp has posted comments on this change. Change subject: IMPALA-2013: Reintroduce steps for checking HBase health in run-hbase.sh ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4348/8/testdata/bin/check-hbase-nodes.py File testdata/bin/check-hbase-nodes.py: Line 88: LOGGER.debug("Success: " + str(zk_client)) > LOGGER.info? Otherwise it looks like we're trying to connect but never succ That's a good catch, but I think it might be OK as-is. This is the output of a typical run: Contents of HDFS root: [u'hbase', u'home', u'test-warehouse', u'tmp', u'user'] Connecting to Zookeeper host(s). Waiting for HBase node: /hbase/master Success: /hbase/master Waiting for HBase node: /hbase/rs Success: /hbase/rs [etc...] The missing line would have been: Success: <kazoo.client.KazooClient object at 0x7f12dda65250> If the connection attempt didn't succeed, I don't think it would be a mystery -- you'd get the exception msg, and the script would exit with an error. Is that acceptable? (Honestly, I think might have intended to take that line out.) -- To view, visit http://gerrit.cloudera.org:8080/4348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b81f3cfb6ea0ba7b18ce5fcd5d268f515c8b0c3 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Ishaan Joshi <ish...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
