Yonghyun Hwang has posted comments on this change. Change subject: IMPALA-3342: Adding new timer to accurately measure the TotalCpuTime ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4633/1/be/src/util/stopwatch.h File be/src/util/stopwatch.h: PS1, Line 237: int64_t utime_diff = (end.ru_stime.tv_sec - start_.ru_stime.tv_sec) * 1000L * 1000L * 1000L : + (end.ru_stime.tv_usec - start_.ru_stime.tv_usec); just 2 simple questions. 1. are we considering "system CPU time" only (excluding "user CPU time")? 2. by any chance, (someone resets resource usage?) can utime_diff be negative? -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Yonghyun Hwang Gerrit-HasComments: Yes
