Tim Armstrong has posted comments on this change. Change subject: Impala-3342 Adding thread counters to measure time spent during plan fragment execution ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4633/2//COMMIT_MSG Commit Message: Line 14: What does the profile look like? Would be helpful to see what the plan fragment profile looks like. http://gerrit.cloudera.org:8080/#/c/4633/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS2, Line 360: SCOPED_THREAD_COUNTER_MEASUREMENT(runtime_state_->plan_fragment_counters()); > Is this thread safe? Yep, scanner_thread_counters() is also shared between scanner threads. http://gerrit.cloudera.org:8080/#/c/4633/2/be/src/runtime/plan-fragment-executor.cc File be/src/runtime/plan-fragment-executor.cc: Line 213: ADD_COUNTER(profile(), PER_HOST_PEAK_MEM_COUNTER, TUnit::BYTES); Let's create the new counter here along with the other ones so that the setup happens in the same place. http://gerrit.cloudera.org:8080/#/c/4633/2/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 241: ///Fragment thread counters The comment isn't too helpful. Maybe: /// Total CPU utilization for all threads in this plan fragment. -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yonghyun Hwang Gerrit-HasComments: Yes
