Henry Robinson has posted comments on this change. Change subject: Impala-3342 Adding thread counters to measure time spent during plan fragment execution ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4633/2//COMMIT_MSG Commit Message: PS2, Line 7: Impala-3342 Adding thread counters to measure time spent during plan : fragment execution Please fix the formatting of the msg. PS2, Line 11: meausure measure PS2, Line 13: hdfs/kudu scanner and in a blocking join Why is this worth calling out? Doesn't this measure all exec nodes? http://gerrit.cloudera.org:8080/#/c/4633/2/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS2, Line 360: SCOPED_THREAD_COUNTER_MEASUREMENT(runtime_state_->plan_fragment_counters()); Is this thread safe? -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Yonghyun Hwang Gerrit-HasComments: Yes
