Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134: Use AUTO_FLUSH_BACKGROUND for Kudu sink ......................................................................
Patch Set 3: (3 comments) Thanks. I made a bunch of changes and ended up making it into a new commit. I'll abandon this one and post a new one with the new changes in a moment. http://gerrit.cloudera.org:8080/#/c/4670/3/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: Line 156: DCHECK(sink_action_ == TSinkAction::DELETE) << "Sink type not supported: " > spurious change here I actually meant to do this Line 163: SCOPED_TIMER(profile()->total_time_counter()); > I wonder if we should still keep some kind of timer which is specifically r Done Line 301: (*state->per_partition_status())[ROOT_PARTITION_KEY].num_appended_rows = > if we don't update this to the end, does the query summary page on the web >From what I can tell, this isn't something that is observable until the >fragment sends its final update to the coordinator. This is a per-partition >(TInsertStats) thing that gets collected at the end of the query. -- To view, visit http://gerrit.cloudera.org:8080/4670 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665ce82d1caf64cf5bdf4bc0e15edbf9f1dc5ba0 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
