David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4678/4/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: PS4, Line 23: normpath Perhaps parentheses around these. It took me a little bit to parse this. (join as join_path, normpath) (Probably would have been easier if I were familiar with normpath.) PS4, Line 55: os.path.sep + join_path('home', DOCKER_USER_NAME, 'Impala', 'testdata', 'cluster') This is a bit long, and make it hard to read. Maybe it could be saved as DEFAULT_TESTDATA_VOLUME_PATH? -- To view, visit http://gerrit.cloudera.org:8080/4678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d9d9253fcd7e3905e389ddeb1438cee3e24480 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-HasComments: Yes
