Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4678/7/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: PS7, Line 142: volume_ops = '-v ' + volume_ops I feel like it's not elegant that we have to add another -v here. How about changing the template in the line above to '-v {host_path}:{container_path}' and removing '-v' from the line 138? This line can then be removed. PS7, Line 171: ): It's interesting that the closing brace is on a separate line. Is this some new style? PS7, Line 312: '' it's a little confusing here, why are there two single quotes followed by a bunch of spaces? -- To view, visit http://gerrit.cloudera.org:8080/4678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d9d9253fcd7e3905e389ddeb1438cee3e24480 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
