Michael Brown has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes ......................................................................
Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/4678/5//COMMIT_MSG Commit Message: PS5, Line 10: use > Would "mount" be an appropriate verb. If so, I think it's more descriptive. Done PS5, Line 19: need the > "need to move the"? Done, but it's not a "move"; it's a copy. PS5, Line 21: rsync > Why rsync versus, say, just cp or mv? This is over a networking virtual layer, so cp won't work. Again, we're not moving data, we're copying it. rsync is more efficient than scp once you've warmed a volume once. It's also convenient to be able to use rsync -a, --chown, and the usage is a lot better than SCP. If you want to do any serious transferring of data, rsync is the better tool. http://gerrit.cloudera.org:8080/#/c/4678/5/tests/comparison/leopard/README File tests/comparison/leopard/README: PS5, Line 17: Basic Configuration > It's a nit, but it might be nicer if this line, and "External Volume Config Done PS5, Line 43: use > "mount external Docker volumes that contain the necessary testdata"? Done PS5, Line 54: path on TARGET_HOST where the : external volume will reside > This is just a directory, right? Yes, and Leopard is responsible for creating it. http://gerrit.cloudera.org:8080/#/c/4678/5/tests/comparison/leopard/impala_docker_env.py File tests/comparison/leopard/impala_docker_env.py: Line 298: if os.environ.get('KUDU_IS_SUPPORTED') == 'true': > Does it makes sense to reference KUDU-1419 here, or at least the README, to Done Line 308: 'rsync -e "ssh -i {priv_key} -o StrictHostKeyChecking=no ' > I'm just curious -- how long does this process take? I timed it last week and it was about 20 minutes in the cold case; almost instantly in the very hot case. -- To view, visit http://gerrit.cloudera.org:8080/4678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d9d9253fcd7e3905e389ddeb1438cee3e24480 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
