Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage ......................................................................
Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4756/1//COMMIT_MSG Commit Message: PS1, Line 7: the > the queries debug page Done http://gerrit.cloudera.org:8080/#/c/4756/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: Line 458: return Status::OK(); > here would be a good place to add an event to indicate Queued Done http://gerrit.cloudera.org:8080/#/c/4756/1/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: PS1, Line 236: : /// The query options from the TClientRequest : const TQueryOptions& query_options_; : RuntimeProfile* summary_profile_; : R > Inspecting the info string is hacky -- but we can avoid having to provide t Done http://gerrit.cloudera.org:8080/#/c/4756/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS1, Line 783: > This ends up being misleading when planning takes a while. I think it'll be Done http://gerrit.cloudera.org:8080/#/c/4756/1/www/queries.tmpl File www/queries.tmpl: PS1, Line 26: {{num_not_scheduled_queries}} queries not scheduled yet > we should get input from a few others about naming. 'scheduling' is somewha Sure, maybe "not yet executing", "pending execution", or "setting up"? PS1, Line 41: <th>Details</th> > Instead of this printed true/false in a separate column, can you add an eve Done PS1, Line 151: <table class='table table-hover table-border'> > We should show the resource pool in this table as well Done -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
