Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage ......................................................................
Patch Set 5: (3 comments) For COMPUTE STATS, the "compute stats" query and both its child queries will be displayed on the /queries page. The child queries operate just like regular queries, eg. they are subject to admission control and can be shown as "Queued". The "compute stats" query is not subject to admission control, and its "Last Event" will be shown as "Planning Finished" while the child queries are running, before moving to "Child queries finished" http://gerrit.cloudera.org:8080/#/c/4756/4/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: PS4, Line 609: queries_json = impa > remove Done PS4, Line 613: assert query['last_event'] != 'Registered' and \ : query['last_event'] != 'Planning finished' : assert query['resource_pool'] == self.pool_name : else: : assert query['resource_pool'] == '' : > This else clause seems a bit weird. The logic would probably be easier if f Done PS4, Line 620: turns the number of queries currently in the 'queued' state from t > In my comment before I meant to give an example rather than something we ca Done -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
