Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage ......................................................................
Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/4756/3/be/src/scheduling/query-schedule.cc File be/src/scheduling/query-schedule.cc: Line 56: is_admitted_(false) { > was this intentional? i don't see why this is necessary Done http://gerrit.cloudera.org:8080/#/c/4756/3/be/src/scheduling/simple-scheduler.cc File be/src/scheduling/simple-scheduler.cc: Line 900: // TODO-MT: call AdmitQuery() rather than always setting is_admitted > call AdmitQuery() rather than always setting is_admitted Done http://gerrit.cloudera.org:8080/#/c/4756/3/be/src/scheduling/simple-scheduler.h File be/src/scheduling/simple-scheduler.h: Line 92: virtual Status Schedule(QuerySchedule* schedule); > Sorry, on second thought this doesn't add much. There's a comment in the ba Done http://gerrit.cloudera.org:8080/#/c/4756/3/be/src/service/query-exec-state.h File be/src/service/query-exec-state.h: PS3, Line 158: and had the pool set yet, > , not had the pool set yet, or this is StmtType doesn't go through admissio Done http://gerrit.cloudera.org:8080/#/c/4756/3/tests/common/impala_service.py File tests/common/impala_service.py: PS3, Line 83: sleep(interval) : assert 0, 'Metric value %s did not reach value %s in %ss' %\ : (metric_name, expected_value, timeout) > can you move this up to be under read_debug_webpage and call it get_debug_w Done http://gerrit.cloudera.org:8080/#/c/4756/3/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: PS3, Line 603: > outdated Done PS3, Line 658: > counts from the queries page Done -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
