Henry Robinson has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4756/5/be/src/service/impala-server.cc File be/src/service/impala-server.cc: PS5, Line 801: Registered I don't think 'Registered' is very meaningful to users (and also it's being set *before* registration, so the time is wrong. "Query submitted" or something might be clearer. The idea is an event that shows that Impala has started processing a query. I preferred it in its earlier place - what was the rationale for moving it? http://gerrit.cloudera.org:8080/#/c/4756/5/be/src/service/query-exec-state.h File be/src/service/query-exec-state.h: Line 157: /// Resource pool associated with this query, or an empty string if the schedule has not Blank line before this. Line 159: // control. missing / PS5, Line 161: NULL nullptr -- To view, visit http://gerrit.cloudera.org:8080/4756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504e3c829a14318721e3a42de6281bcc578f7283 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
