anujphadke has posted comments on this change. Change subject: IMPALA-3342: Add thread counters to monitor plan fragment execution ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/4633/6//COMMIT_MSG Commit Message: Line 9: This change removes the use of total_cpu_timer which incorrectly > Can you provide an example of how the profile looks now? Otherwise the chan Do you mean provide a snippet of the profile in the commit message? http://gerrit.cloudera.org:8080/#/c/4633/6/be/src/runtime/runtime-state.h File be/src/runtime/runtime-state.h: Line 242: RuntimeProfile::ThreadCounters* plan_fragment_counters_; > This member variable should be private. We access this object variable in plan-fragment-executor.Hence I kept it public unlike in scan-node where ThreadCounters are kept protected and are accessed directly. Should I add a setter too for this? I did not do it since its usage did not look consistent. -- To view, visit http://gerrit.cloudera.org:8080/4633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa88aa6f3371fa42d11ecc122f43c7d83623c300 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-HasComments: Yes
