Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case ......................................................................
Patch Set 2: test_describe_formatted did not catch this bug because it was silently failing. The primary issue there was that it wasn't passing a 'transport' param to the jdbc client, and it uses the workload runner infrastructure, which logs errors it encounters but doesn't fail tests (in query_exec_functions.py:run_query_capture_results). To prevent other tests from making the same mistake, I added an assert in JdbcQueryExecConfig that ensures that the transport is set. There was also an incorrect number of parameters being passed to the HiveQueryResult constructor in create_exec_result that I fixed. Finally, it turns out that we handle NULLs differently from Hive. For now, I've left our NULL behavior as is, and just modified the test to allow NULLs to equal empty strings, which also allowed me to remove an xfail from the test. -- To view, visit http://gerrit.cloudera.org:8080/4861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I274b97d4d1247244247fb38a5ca7f4c10bba8d22 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: No
