Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4861/2/tests/metadata/test_metadata_query_statements.py File tests/metadata/test_metadata_query_statements.py: PS2, Line 84: results, > Sorry maybe I am missing something here, but isn't lower() applied on the e RIght, except that after calling lower() it never directly compares the two strings to each other again, it just compares them to 'null' and ''. So if Impala return 'STRING' and Hive return 'string', they won't match, then we'lll call replace() and lower(), and convert the impala output to 'string' and then 'not ((impala == "'null'" and hive == "''") or (impala == "''" and hive == "'null'"))' will be false and we'll return false. -- To view, visit http://gerrit.cloudera.org:8080/4861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I274b97d4d1247244247fb38a5ca7f4c10bba8d22 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
