Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4861/2/tests/metadata/test_metadata_query_statements.py File tests/metadata/test_metadata_query_statements.py: PS2, Line 84: results, > This only impacts the comparison of NULL vs. empty string. I expanded the a Sorry maybe I am missing something here, but isn't lower() applied on the entire impala and hive output. So my understanding is that if Impala returns let's say 'STRING' and and Hive returns 'string', then by calling lower() the output will be the same and we will not catch inconsistencies in the generated output. -- To view, visit http://gerrit.cloudera.org:8080/4861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I274b97d4d1247244247fb38a5ca7f4c10bba8d22 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
