Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage ......................................................................
Patch Set 6: (5 comments) Thanks, a few small things and I'm gonna follow up with you about validation. http://gerrit.cloudera.org:8080/#/c/4953/6//COMMIT_MSG Commit Message: Line 16: test along with the RESULTS or ERRORS sections. TODO: Refactor the DML test case handling (IMPALA-4471) http://gerrit.cloudera.org:8080/#/c/4953/6/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test: PS6, Line 216: erros typo http://gerrit.cloudera.org:8080/#/c/4953/6/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: Line 344: # different result sets to consider. to consider (IMPALA-4471). http://gerrit.cloudera.org:8080/#/c/4953/6/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: Line 303: to make it possible to have regular RESULTS/ERRORS sections in tests with DML_RESULTS Reference IMPALA-4471 http://gerrit.cloudera.org:8080/#/c/4953/6/tests/util/test_file_parser.py File tests/util/test_file_parser.py: PS6, Line 230: if subsection_name == 'DML_RESULTS': We need a comment explaining a summary of what this is. Can you add this: The presence of the DML_RESULTS section is used to specify what the state of the table should be after executing a DML query (in the QUERY section). The target table name must be specified in a table comment, and then the expected rows in the table are the contents of the section. If the TYPES and LABELS sections are provided, they will be verified against the DML_RESULTS. Using both DML_RESULTS and RESULTS is not supported. -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
