Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/4953/6/testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test: PS6, Line 216: error > typo Done http://gerrit.cloudera.org:8080/#/c/4953/6/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: Line 344: # different result sets to consider (IMPALA-4471). > to consider (IMPALA-4471). Done http://gerrit.cloudera.org:8080/#/c/4953/6/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: Line 303: to allow regular RESULTS/ERRORS sections in tests with DML_RESULTS (IMPALA-4471). > Reference IMPALA-4471 Done http://gerrit.cloudera.org:8080/#/c/4953/6/tests/util/test_file_parser.py File tests/util/test_file_parser.py: PS6, Line 230: # The DML_RESULTS section is used to > We need a comment explaining a summary of what this is. Can you add this: Done -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
