Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage ......................................................................
Patch Set 11: Code-Review+2 (1 comment) Reviewed the new test cases that were added. I assume there weren't other changes to the UPSERT tests or the python infra code, right? http://gerrit.cloudera.org:8080/#/c/4953/11/testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test File testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test: Line 39: insert into tdata values (3, cast('nan' as float), max_bigint(), '', true, min_tinyint(), max_smallint(), cast('-inf' as double)) wrap long line -- To view, visit http://gerrit.cloudera.org:8080/4953 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
