Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp ......................................................................
Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5251/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 3616: "as timestamp), interval 13 months) as string)", odd indentation. could you try to fix the formatting rules? http://gerrit.cloudera.org:8080/#/c/5251/4/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: Line 54: void ThrowExceptionIfTimestampOutOfRange(const boost::gregorian::date& date) { > We need to catch exceptions anyway in the caller anyway, since other boost remove Exception, it's implied in Throw. remove Timestamp, you're not checking a timestamp. -- To view, visit http://gerrit.cloudera.org:8080/5251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc427b06ac33ec874a05cb98d01c00e970d3dde6 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
