Dan Hecht has posted comments on this change. Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp ......................................................................
Patch Set 4: > > What about the try/catch block in timestamp-functions-ir.cc. > > Shouldn't that code be moved into the native code so that it > > actually works? > > > > Also, maybe we should add try/catch in TimestampValue::DebugString() > > to be safe? > > The question is where to stop. We should really audit all of our > boost calls for uncaught exceptions. Sure, but these ones are already known to be problematic. -- To view, visit http://gerrit.cloudera.org:8080/5251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc427b06ac33ec874a05cb98d01c00e970d3dde6 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
