Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
......................................................................


Patch Set 4:

(2 comments)

Dan: so there's actually a special case in exprs/scalar-fn-call.cc that 
disables codegen for functions with "AddSub" in the name. This is a bit of a 
hack and could be cleaned up in various way.

I also experimented with disabling that hack and it looks like exception 
handling in IR actually works to some extent, so maybe it's worth reevaluating 
later. I wonder if we should just move some of those functions to 
timestamp-functions.cc, since I don't think we're using the IR.

http://gerrit.cloudera.org:8080/#/c/5251/4/be/src/exprs/expr-test.cc
File be/src/exprs/expr-test.cc:

Line 3616:                   "as timestamp), interval 13 months) as string)",
> odd indentation.
I don't think it's configurable - it wants to line up the multi-line strings 
and there's no option I could find to disable that.

Manually reverted it.


http://gerrit.cloudera.org:8080/#/c/5251/4/be/src/exprs/timestamp-functions.cc
File be/src/exprs/timestamp-functions.cc:

Line 54: void ThrowExceptionIfTimestampOutOfRange(const boost::gregorian::date& 
date) {
> remove Exception, it's implied in Throw.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc427b06ac33ec874a05cb98d01c00e970d3dde6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to