Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. ......................................................................
Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4960/2//COMMIT_MSG Commit Message: Line 7: IMPALA-3167: Fix assignment of WHERE-clause predicate through grouping agg + outer join. long lines Line 28: The fix is to conservatively not mark bound predicates as assigned if there exists if there are Line 30: duplicate assignments of predicates. Those are simply deduped now. i don't understand that last part. http://gerrit.cloudera.org:8080/#/c/4960/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 1548: (evalAfterJoin(srcConjunct) move to preceding line and fix indentation, like l1551 Line 1550: != globalState_.outerJoinedTupleIds.get(srcTid))) fix indentation Line 1553: != globalState_.outerJoinedTupleIds.get(destTid))); same here http://gerrit.cloudera.org:8080/#/c/4960/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: Line 1194: Expr.removeDuplicates(conjuncts); how do you end up with duplicate predicates in a *scan* node due to the changes in analyzer? (and why is this only relevant for hdfs scans?) -- To view, visit http://gerrit.cloudera.org:8080/4960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I774d13a13ad1e8fe82512df98dc29983bdd232eb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Anonymous Coward #27 Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
