Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4960/3//COMMIT_MSG Commit Message: Line 32: Change-Id: I774d13a13ad1e8fe82512df98dc29983bdd232eb what does 'equivalent outer-joined tuples' mean? (equivalent to what?) http://gerrit.cloudera.org:8080/#/c/4960/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 1542: // after the join (IMPALA-2018/4379). The first condition is conservative but what does 'after *the* join' mean? in your example test case, the predicate doesn't come from a join. http://gerrit.cloudera.org:8080/#/c/4960/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: Line 1194: Expr.removeDuplicates(conjuncts); > Explained duplicates in commit msg with an example. i agree in principle, but isn't that a trivial change? -- To view, visit http://gerrit.cloudera.org:8080/4960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I774d13a13ad1e8fe82512df98dc29983bdd232eb Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Anonymous Coward #27 Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
