Alex Behm has posted comments on this change. Change subject: IMPALA-3167: Fix assignment of WHERE conjunct through grouping agg + OJ. ......................................................................
Patch Set 3: (3 comments) I'm going to start the GVO, but please feel free to post additional comments, I'll be sure to take care of them. http://gerrit.cloudera.org:8080/#/c/4960/3//COMMIT_MSG Commit Message: Line 32: there are equivalent outer-joined tuples. As a result, a plan node may > what does 'equivalent outer-joined tuples' mean? (equivalent to what?) Thanks for reading carefully. Rephrased to me more precise. http://gerrit.cloudera.org:8080/#/c/4960/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 1542: // after the join (IMPALA-2018/4379). The first condition is conservative but > what does 'after *the* join' mean? in your example test case, the predicate Rephrased. Let me know if it needs further polish. http://gerrit.cloudera.org:8080/#/c/4960/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: Line 1194: Expr.removeDuplicates(conjuncts); > i agree in principle, but isn't that a trivial change? It's a trivial change yes, but I feel like we should minimize the changes in this bugfix for easier backporting. Thanks for flexibility, I'll address the propagation issue in a follow-on patch. -- To view, visit http://gerrit.cloudera.org:8080/4960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I774d13a13ad1e8fe82512df98dc29983bdd232eb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #27 Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
