Michael Brown has posted comments on this change.

Change subject: IMPALA-4567: Fix test_kudu_alter_table exhaustive failures
......................................................................


Patch Set 2:

I see this is already submitted, but:

> Do you know how I can only run 1 of the 2 (e.g. just codegen enabled) for 
> this particular test fn?

To be safe, I think the mark for serial is still a good idea, since the test 
truly needs to be serial.

A quick method would simply be to inspect something in the vector and 
pytest.skip(), or separating out the Kudu DDL stuff separately into a separate 
class that only uses 1 dimension. There's no great, perfect solution available 
to us at this time though.

-- 
To view, visit http://gerrit.cloudera.org:8080/5312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibca64d5567c24240606e454b052d130fcd0c3968
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No

Reply via email to