Jim Apple has posted comments on this change.

Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr().
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5589/2/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

PS2, Line 335: 1
Can the occurrence argument be 0?


PS2, Line 349: 7
What if occurrence is off the end of the string?

    instr('a', 'a', 2)


PS2, Line 395: negative position argument
Can the occurrence argument be zero or negative?


Line 406: select instr('hello world','o',-1);
Can you show an example with a negative position argument and an occurrence 
argument?


-- 
To view, visit http://gerrit.cloudera.org:8080/5589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <[email protected]>
Gerrit-Reviewer: Anonymous Coward #268
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Zoltan Ivanfi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to