Jim Apple has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5589/2/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: PS2, Line 335: 1 > Same as the "off the end of the string" possibility below. The 'occurrence' Can you add a note to say that in this doc? PS2, Line 395: negative position argument > That particular circumstance causes an error instead of a zero return value Can the behavior be explicitly called out in this patch's contents? Line 406: select instr('hello world','o',-1); > Sure. In general, we try to be more detailed than Hive when it comes to pro I do not see a patch set 3 here yet. Are you planning on sending that in a later patch, or just haven't gotten to it yet? -- To view, visit http://gerrit.cloudera.org:8080/5589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
