Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-3973: optional 2nd and 3rd arguments for instr(). ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5589/2/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: PS2, Line 395: negative position argument > That particular circumstance causes an error instead of a zero return value That's intentional. In fact, initially I returned 0 in this case as well, but then acting on Dan Hecht's recommendation I checked this behavior in Oracle and found that Oracle gives an error in this case, so we do the same. Related discussion can be found on https://gerrit.cloudera.org/#/c/4094/13/be/src/exprs/string-functions-ir.cc@292 -- To view, visit http://gerrit.cloudera.org:8080/5589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17268bdb480230938f94559fe1eabe34ac2448b7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: John Russell <[email protected]> Gerrit-Reviewer: Zoltan Ivanfi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
