Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5631/1//COMMIT_MSG Commit Message: PS1, Line 9: THe problem here is that remove PS1, Line 13: earlier avoid ambiguous terms earlier and later Line 15: in BinaryPredicate.toThrift. It looks to me like the issue that the 'folded' constant may just have a different type than the type in the BinaryPredicate: e.g. TINYINT and INT respectively decode(0, 1, 1, id, 1) Is that correct? If so, that may be a more clear way to describe it. Also giving an example helps. http://gerrit.cloudera.org:8080/#/c/5631/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java: Line 238: RewritesOk("decode(0, 1, 0, id, 1)", rule, "decode(0, 1, 0, id, 1)"); to be clear, this threw the IllegalStateEx before your change? -- To view, visit http://gerrit.cloudera.org:8080/5631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4de9ed7118c8d18ec3f02ff74c9cca211c716e51 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
